Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bootstrap.py: fix build-failure message #107808

Merged
merged 1 commit into from
Feb 9, 2023
Merged

bootstrap.py: fix build-failure message #107808

merged 1 commit into from
Feb 9, 2023

Conversation

kadiwa4
Copy link
Contributor

@kadiwa4 kadiwa4 commented Feb 8, 2023

A small mistake I did.
Corrects #107470, fixes #107804

r? @albertlarsan68 (since you reviewed the last one)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Feb 8, 2023
@kadiwa4 kadiwa4 force-pushed the built-unsuccessfully branch from e6e37cd to 62edacf Compare February 9, 2023 07:59
@albertlarsan68
Copy link
Member

Thanks!
@bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 9, 2023

📌 Commit 62edacf has been approved by albertlarsan68

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 9, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 9, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 9, 2023
@bors
Auto merge of rust-lang#107840 - matthiaskrgr:rollup-e6v7x0a, r=matth…
5919f62 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#107446 (Migrate some of `rustc_parse` to derive diagnostics)
 - rust-lang#107752 (Specify dlltool prefix when generating import libs)
 - rust-lang#107808 (bootstrap.py: fix build-failure message)
 - rust-lang#107834 (create symlink for legacy rustfmt path)
 - rust-lang#107835 (use idiomatic formatting)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a3e152c into rust-lang:master Feb 9, 2023
@rustbot rustbot added this to the 1.69.0 milestone Feb 9, 2023
@kadiwa4 kadiwa4 mentioned this pull request Feb 9, 2023
Merged
@kadiwa4 kadiwa4 deleted the built-unsuccessfully branch February 9, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyn514 jyn514 jyn514 left review comments

@compiler-errors compiler-errors compiler-errors left review comments

@madsravn madsravn madsravn left review comments

Assignees

@albertlarsan68 albertlarsan68

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.69.0
Development

Successfully merging this pull request may close these issues.

Bootstrap no longer prints "Build completed unsuccessfully when it exits with an error
7 participants
@kadiwa4 @albertlarsan68 @bors @madsravn @compiler-errors @jyn514 @rustbot